fishy commented on code in PR #2708:
URL: https://github.com/apache/thrift/pull/2708#discussion_r995188875


##########
lib/go/thrift/type.go:
##########
@@ -38,9 +38,7 @@ const (
        MAP    = 13
        SET    = 14
        LIST   = 15
-       UTF8   = 16
-       UTF16  = 17
-       //BINARY = 18   wrong and unusued
+       UUID   = 16

Review Comment:
   looking at https://github.com/apache/thrift/commits/v0.17.0 I _think_ the 
only thing uuid related included in the stable release was the spec, so we 
definitely should fix java/kotlin/swift to match the spec instead :)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to