dcelasun commented on code in PR #2708:
URL: https://github.com/apache/thrift/pull/2708#discussion_r995185040


##########
lib/go/thrift/type.go:
##########
@@ -38,9 +38,7 @@ const (
        MAP    = 13
        SET    = 14
        LIST   = 15
-       UTF8   = 16
-       UTF16  = 17
-       //BINARY = 18   wrong and unusued
+       UUID   = 16

Review Comment:
   ~~UUID=17 has already been included in a stable release. We should either 
correct that with a breaking change, or update the spec and the Go 
implementation to be consistent.~~
   
   ~~Neither option is attractive.~~
   
   I was mistaken, see below.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to