jeking3 commented on code in PR #2719:
URL: https://github.com/apache/thrift/pull/2719#discussion_r1004936388
##########
.github/workflows/build.yml:
##########
@@ -275,6 +275,11 @@ jobs:
steps:
- uses: actions/checkout@v3
+ - name: Setup Swift
+ uses: swift-actions/[email protected]
+ with:
+ swift-version: "5.7"
Review Comment:
I would advise using the build containers over building an environment with
GHA for every CI job (as it was, in the past). Builds will take longer if you
have to pull in every language like this, as opposed to downloading a one-time
generated build container with everything in it. With a build container anyone
can use it to build the entire package locally and the local build is the same
as the CI build. With GHA scripted build environments like this, only GHA can
run the build.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
