emmenlau commented on PR #2633:
URL: https://github.com/apache/thrift/pull/2633#issuecomment-1296169851
Dear @africamonkey , I'm really sorry but I'm not all too deep in that code
and find it slightly difficult to wrap my head around the implementation. Can
you explain the logic, either in a comment in the code, or here in the chat?
Basically my questions are:
- Why was the old implementation incorrect and/or is your new
implementation better?
- Why is the `!=` operator not just calling the `==` operator and returning
the negated result?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
