Jimexist commented on code in PR #2727:
URL: https://github.com/apache/thrift/pull/2727#discussion_r1024651621
##########
compiler/cpp/src/thrift/generate/t_java_generator.cc:
##########
@@ -503,6 +510,89 @@ string t_java_generator::java_override_annotation() {
return "@Override";
}
+map<string, int> t_java_generator::get_keywords_list() const
+{
+ return java_keywords;
+}
+
+void t_java_generator::init_keywords()
+{
+ java_keywords.clear();
+
+ // according to Oracle docs
+ java_keywords["abstract"] = 1;
Review Comment:
can we just create an array and populate the map from that?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
