hdclark commented on PR #2649:
URL: https://github.com/apache/thrift/pull/2649#issuecomment-1335648315
+1
I'm encountering the same case sensitivity issue using MXE to cross-compile
on Linux for Windows. Compiling only the libraries using the current master
branch, the following includes needed to be fixed:
```
lib/cpp/src/thrift/transport/THttpServer.cpp:29 Shlwapi.h -> shlwapi.h
lib/cpp/src/thrift/transport/TServerSocket.cpp:73 Windows.h -> windows.h
lib/cpp/src/thrift/windows/Sync.h:40 Windows.h -> windows.h
lib/cpp/src/thrift/transport/TPipeServer.cpp:30 AccCtrl.h -> accctrl.h
lib/cpp/src/thrift/transport/TPipeServer.cpp:30 Aclapi.h -> aclapi.h
lib/cpp/src/thrift/windows/SocketPair.cpp:37 WS2tcpip.h -> ws2tcpip.h
```
In absence of a patch, the following also worked for me on both v0.17.0
release and current master branch:
```
find repo_root/ \
-type f \( -iname '*.h' -o -iname '*.cpp' \) \
-exec sed -i -e 's/Windows[.]h/windows.h/g' \
-e 's/Shlwapi[.]h/shlwapi.h/g' \
-e 's/AccCtrl[.]h/accctrl.h/g' \
-e 's/Aclapi[.]h/aclapi.h/g' \
-e 's/WS2tcpip[.]h/ws2tcpip.h/g' '{}' \+
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
