nicolasb29 commented on code in PR #2746:
URL: https://github.com/apache/thrift/pull/2746#discussion_r1090014004
##########
lib/java/src/main/java/org/apache/thrift/TException.java:
##########
@@ -20,7 +20,7 @@
package org.apache.thrift;
/** Generic exception class for Thrift. */
-public class TException extends Exception {
+public class TException extends RuntimeException {
Review Comment:
@Jimexist It's due to Apache HttpComponent 5, good usage is to use http call
code in lambda.
##########
lib/java/gradle.properties:
##########
@@ -25,14 +25,14 @@
maven-repository-url=https://repository.apache.org/service/local/staging/deploy/
maven-repository-id=apache.releases.https
# Dependency versions
-httpclient.version=4.5.13
-httpcore.version=4.4.15
+httpclient.version=5.2.1
+httpcore.version=5.2
Review Comment:
@Jimexist
To migrate to Apache Http Components 5, it's mandatory but if it is only to
migrate to Jakarta namespace, it's not.
I can create another pull request for the migration of Apache HttpComponent
4 to 5 but I think it's very important because :
- HttpClient5 is being actively maintained and HttpClient 4 is not (last
important release was updated on Oct 06 2020, 4.5.14 was release in December
2022 but only with several minor correction on the core part) : [News Apache
Http](https://hc.apache.org/news.html) so more and more developers are using
5.x version
- Framework like Spring Boot 3.x is using Apache HttpClient 5.x (for example
in ClientHttpRequestFactory)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
