kashirin-alex commented on PR #2755: URL: https://github.com/apache/thrift/pull/2755#issuecomment-1494063151
Regarding the main subject , definitions in header and impl. in source files. Agree. Undefined type for pointer storage is understandable but storage without pre defined size for dynamic or not container is a mistake. I haven't checked but I'm sure std::array would not let to compile. On Mon, Apr 3, 2023, 12:44 PM Kashirin Alex ***@***.***> wrote: > That would been my next list of things todo, whereas part of app-dev, it > requires extended Flags, for client interface library to be compatible with > all pedantic kind of flags. > > I think, These flags, with the generated code use, can indicate that the > mission is accomplished: > -Wdeprecated-copy-dtor > -Weffc++ > > > On Mon, Apr 3, 2023, 12:15 PM Lukas Barth ***@***.***> > wrote: > >> I would love to move forward with this. I think this is more or less a >> necessary precondition to use Apache Thrift with C++20 - and even before >> C++20, the previous behavior is UB. We are using a Thrift version with this >> patch in production by now. Maybe a review of my proposed changes could be >> a first step towards a merge? >> >> @Jens-G <https://github.com/Jens-G> @cyyever <https://github.com/cyyever> >> @kashirin-alex <https://github.com/kashirin-alex> @zeshuai007 >> <https://github.com/zeshuai007> @dsandbrink >> <https://github.com/dsandbrink> you contributed to this file >> "relatively" recently (although it was potentially several years ago - >> there is not much movement in this file). Maybe one of you would feel up to >> the task? Thanks a lot in advance! >> >> — >> Reply to this email directly, view it on GitHub >> <https://github.com/apache/thrift/pull/2755#issuecomment-1493966592>, or >> unsubscribe >> <https://github.com/notifications/unsubscribe-auth/ABHLKBNUJ3STDTJV7HJWZO3W7KILBANCNFSM6AAAAAAUU67ON4> >> . >> You are receiving this because you were mentioned.Message ID: >> ***@***.***> >> > -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
