Jimexist commented on code in PR #2779:
URL: https://github.com/apache/thrift/pull/2779#discussion_r1161388525
##########
.github/workflows/build.yml:
##########
@@ -137,14 +137,14 @@ jobs:
needs: compiler
runs-on: ubuntu-20.04
env:
- GRADLE_VERSION: "7.6"
+ GRADLE_VERSION: "8.0.2"
steps:
- uses: actions/checkout@v3
- uses: actions/setup-java@v3
with:
distribution: temurin
- java-version: 17
+ java-version: 19
Review Comment:
for maintainability i think we should stick with 11 for released jars (which
is guaranteed using `-release` flag). i trust JDK's capability of
down-compiling with newer Java versions.
for build tool chain (CI) i think it is okay to move along with newest
stable release.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
