fishy commented on PR #2776: URL: https://github.com/apache/thrift/pull/2776#issuecomment-1502109947
So I tried this change on our code, the bit shift one is actually easy to fix (just cast to `int64` before doing bit shifting), but after that is fixed we saw a bunch of tests now breaking, so I agree with @dcelasun that this could be a big backward compatibility break that's not worth it (especially considering that the harm of not fixing it is very limited). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
