fishy commented on code in PR #2783:
URL: https://github.com/apache/thrift/pull/2783#discussion_r1169101452
##########
test/py/SerializationTest.py:
##########
@@ -351,6 +354,12 @@ def testRecVector(self):
out_list = self._collapseLinkedList(cur_list)
self.assertEqual(golden_list, out_list)
+ def testDefaultEnum(self):
+ """Ensure default enum values are serializable"""
+ obj = self._deserialize(OptionalEnum,
self._serialize(self.optional_enum))
+ self.assertEquals(obj, self.optional_enum)
+
+
Review Comment:
excessive blank lines. I think the general python style is 2 blank lines
between classes/top level stuff and one blank line between functions inside the
same class. here you are making it 3 blank lines between classes.
##########
test/py/SerializationTest.py:
##########
@@ -451,6 +460,8 @@ def _enumerate_enum(enum_class):
self.assertEquals(obj, objcopy)
+
+
Review Comment:
same here, you are making it 4 blank lines between the class above and
`suite`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
