Jimexist commented on PR #2785: URL: https://github.com/apache/thrift/pull/2785#issuecomment-1517134748
> @ctubbsii Don't think we're going to agree on this one. > > > Those contributors are likely to face questions like: "can you rewrite this in a Java 8 way?" or "is this really important enough of a feature to justify moving to 11?". > > This didn't happen since May 2022 since it still compiles perfectly fine against Java 8... > > > Again, I will say it: you do not have to update. But that's your choice because it's better for your project. Thrift should still be able to update in its next releases, because that's better for the Thrift project. > > I also disagree there. I think it is best for Thrift as well to cater to the widest possible audience. Interoperability? > > > They don't have to upgrade Thrift so aggressively. > > Of course, this is true, but as you can see in the maven central screenshot above, there are security vulnerabilities. Also, it potentially blocks upgrading the transitive dependencies of Thrift. Also, I like to use UUIDs. > > Anyway. I've updated the CI. Against Kotlin it is still Java11+ because the formatter doesn't work with Java8. I think @ctubbsii has a point in that there's no perfect timing for thrift to upgrade - any time any one adds some new functionality it'll be hard to anyone still on Java 8 to pick it up if the upgrade is done. And sadly also there's no way to distribute with source instead of `.class` via maven central. Can you find a counter argument that say maybe by 2024 it is a good time for thrift to upgrade to Java 11+? How about if later when I want to introduce https://docs.oracle.com/en/java/javase/11/docs/api/java.net.http/java/net/http/HttpClient.html into the package? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
