Jens-G commented on code in PR #2815: URL: https://github.com/apache/thrift/pull/2815#discussion_r1222200481
########## lib/swift/Tests/ThriftTests/TJSONProtocolTests.swift: ########## @@ -0,0 +1,212 @@ +// +// File.swift +// +// Created by Khodabakhsh, Hojjat on 5/18/23. +// + +import XCTest Review Comment: please replace the file header by std ASF license header ########## lib/swift/Sources/TBase64Utils.swift: ########## @@ -0,0 +1,89 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +import Foundation + +public class TBase64Utils { + private static let EncodeTable: String = "ABCDEFGHIJKLMNOPQRSTUVWXYZabcdefghijklmnopqrstuvwxyz0123456789+/" Review Comment: Do we really need to implement this ourselves? Does Swift have no standard runtime library support for this that we can leverage? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
