KTAtkinson commented on code in PR #2816:
URL: https://github.com/apache/thrift/pull/2816#discussion_r1238799949
##########
test/py/TestClient.py:
##########
@@ -256,6 +257,19 @@ def testMultiException(self):
y = self.client.testMultiException('success', 'foobar')
self.assertEqual(y.string_thing, 'foobar')
+ def testExceptionInContextManager(self):
Review Comment:
I think there should be some sort of test here. I originally wrote the test
testing the functionality directly, assigning and deleting particular
attributes. I wasn't able to write a test to ensure that user defined
attributes are not editable as in some cases they are editable.
My thinking with this test case is that it will at least catch the specific
failure when Thrift is updated to use Python 3.11. I did try to run this test
with 3.11 but there are parts of the test script that aren't compatible with
3.11.
Thoughts on how to effectively write at test here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
