fishy commented on code in PR #2822: URL: https://github.com/apache/thrift/pull/2822#discussion_r1244272575
########## test/py/explicit_module/runtest.sh: ########## @@ -23,9 +23,12 @@ rm -rf gen-py ../../../compiler/cpp/thrift --gen py test1.thrift || exit 1 ../../../compiler/cpp/thrift --gen py test2.thrift || exit 1 ../../../compiler/cpp/thrift --gen py test3.thrift && exit 1 # Fail since test3.thrift has python keywords +../../../compiler/cpp/thrift --gen py:enum shared_types.thrift || exit 1 +../../../compiler/cpp/thrift --gen py:enum test4.thrift || exit 1 Review Comment: I wonder if we could also have tests without `enum` arg to make sure that it also works in that case. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
