roshanjrajan-zip commented on PR #2824: URL: https://github.com/apache/thrift/pull/2824#issuecomment-1613799073
> right but this is python so it's very hard to force anything, I guess? we don't even have type annotation (I believe there's an open ticket for that just no one picking it up yet). > > so even if we move the logic to constructor the risk of someone doing other thing to override it is. I guess the current approach makes sense in the given circumstances. We can force this to be an enum by refusing to parse the value if it's a string but that would be a breaking change. I think its the right thing to do and I am okay with making this change as I'm pretty certain very few people use this functionality because it doesn't really make sense when interchanging strings/enums. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
