roshanjrajan-zip commented on code in PR #2825: URL: https://github.com/apache/thrift/pull/2825#discussion_r1248317868
########## test/py/explicit_module/runtest.sh: ########## @@ -25,10 +25,12 @@ rm -rf gen-py ../../../compiler/cpp/thrift --gen py test3.thrift && exit 1 # Fail since test3.thrift has python keywords ../../../compiler/cpp/thrift --gen py:enum shared_types.thrift || exit 1 ../../../compiler/cpp/thrift --gen py:enum test4.thrift || exit 1 +../../../compiler/cpp/thrift --gen py:enum test5.thrift || exit 1 Review Comment: NVM I figured it out and it seems to work. Is there a specific test case you have in mind? I just changed this - `../../../compiler/cpp/thrift --gen py:enum,slots test5.thrift` and the new serialization/deserialization test that I added works. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
