arkuhn commented on code in PR #2523:
URL: https://github.com/apache/thrift/pull/2523#discussion_r1269676217
##########
compiler/cpp/src/thrift/generate/t_py_generator.cc:
##########
@@ -2497,6 +2524,11 @@ void t_py_generator::generate_serialize_field(ostream&
out, t_field* tfield, str
* @param prefix String prefix to attach to all fields
*/
void t_py_generator::generate_serialize_struct(ostream& out, t_struct*
tstruct, string prefix) {
+ if(gen_type_hints_) {
+ indent(out) << "if not type(" << prefix << ") is " <<
type_to_py_type(tstruct)
Review Comment:
I think I agree with @jeking3 that this goes beyond type hinting and is a
behavioral change that might deserve its own PR and discussion. Any opposition
to backing this part of the diff out so the non-controversial type hints can
land?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
