catenacyber commented on PR #2886:
URL: https://github.com/apache/thrift/pull/2886#issuecomment-1824398585

   > this changes removes `go.mod`/`go.sum` under `lib/go/test/fuzz` (they are 
now generated on-the-fly by `make check` now), which _might_ affect how 
oss-fuzz runs. based on the [previous 
PR](https://github.com/apache/thrift/pull/2724) the impact might be minimal but 
just want to make sure :)
   
   Fails with oss-fuzz
   `python3 infra/helper.py build_fuzzers thrift` with patched Dockerfile
   ```
   -RUN git clone --depth 1 https://github.com/apache/thrift
   +RUN git clone --depth 1 --branch go-run-tests 
https://github.com/fishy/thrift
   ```
   
   > it would be great if oss-fuzz can use go's native fuzz implementation 
instead.
   
   @AdamKorcz this is now the case, right ?
   See 
https://google.github.io/oss-fuzz/getting-started/new-project-guide/go-lang/#native-go-fuzzing-support


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to