fishy commented on code in PR #2931: URL: https://github.com/apache/thrift/pull/2931#discussion_r1495054745
########## .github/workflows/pypi.yml: ########## @@ -0,0 +1,32 @@ +name: "PyPI publishing" Review Comment: we don't have license header on other github action workflow files currently either: - https://github.com/apache/thrift/blob/master/.github/workflows/build.yml - https://github.com/apache/thrift/blob/master/.github/workflows/cmake.yml since this is a cherry-pick of #2928 we already merged, if we deem it necessary to add license header to all 3 files I'd suggest we do them in separated PR (probably after 0.20.0 release), what do you think? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
