sveneld commented on code in PR #2932:
URL: https://github.com/apache/thrift/pull/2932#discussion_r1497056753
##########
lib/php/test/Unit/BaseValidatorTest.php:
##########
@@ -114,27 +120,35 @@ protected static function assertHasReadValidator($class)
{
if (!static::hasReadValidator($class)) {
static::fail($class . ' class should have a read validator');
+ } else {
+ static::assertTrue(true);
}
}
protected static function assertNoReadValidator($class)
{
if (static::hasReadValidator($class)) {
static::fail($class . ' class should not have a write validator');
+ } else {
+ static::assertTrue(true);
}
Review Comment:
if this check will be absent we will receive a warning that test does not
make any assert, so if everything fine we should get a success assert
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
