sveneld commented on code in PR #2934:
URL: https://github.com/apache/thrift/pull/2934#discussion_r1499611015
##########
lib/php/lib/ClassLoader/ThriftClassLoader.php:
##########
@@ -101,8 +102,9 @@ public function register($prepend = false)
*/
public function loadClass($class)
{
- if ((true === $this->apcu && ($file = $this->findFileInApcu($class)))
or
- ($file = $this->findFile($class))
+ if (
Review Comment:
PSR-12 suggest to write "if" in this style.
It future i will try to migrate php code to psr-12 and add code style check,
but first of all we should write tests and migrate to new php version
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
