k-walton commented on PR #2946: URL: https://github.com/apache/thrift/pull/2946#issuecomment-2005083271
@fishy I've added the test to validate that the benchmark's memory allocation is below a threshold. I chose the `AllocedBytesPerOp()` stat to make a limit, due to the normal protocol buffer reads using allocations as well making the results less clear. I'll add the before and after below. Before change: ``` === RUN BenchmarkSimpleJsonStringParse_Allocations BenchmarkSimpleJsonStringParse_Allocations BenchmarkSimpleJsonStringParse_Allocations-10 5881 222369 ns/op 1073930 B/op 2016 allocs/op ``` After change: ``` === RUN BenchmarkSimpleJsonStringParse_Allocations BenchmarkSimpleJsonStringParse_Allocations BenchmarkSimpleJsonStringParse_Allocations-10 28100 41955 ns/op 15440 B/op 1027 allocs/op ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@thrift.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
