emmenlau commented on PR #2964: URL: https://github.com/apache/thrift/pull/2964#issuecomment-2074523078
I think this is a valid request. But it needs more discussion. Probably this should be moved to Jira. ## General Context Currently the Thrift server is implemented such that it will end on all server-side exceptions. This is not only in the case you found, there are other cases that may trigger the server to end. In my humble opinion, the server should never end. I assume that an action that triggers an exception in the server is a "fault" of the client, and the exception should be passed down to the client as the correct receiver. We have modified the server to act in this way. Basically, we wrap the full server in the relevant try-catch-clocks, and pass all possible exceptions to the client. However this changes a fundamental design of Thrift. While I would argue that this is an improvement for any user, it still requires discussion. What do others think? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@thrift.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
