fishy commented on PR #2950: URL: https://github.com/apache/thrift/pull/2950#issuecomment-2075972715
Please: 1. Create a JIRA ticket to describe the issue (with what's the current generated code and what should be the correct code) 2. Resolve the merge conflicts (java failing should be fixed on latest master version) 3. Create an unit test under `lib/nodejs/test/` (or maybe `lib/js/test/`?) to verify this fix -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@thrift.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
