fishy commented on code in PR #2973:
URL: https://github.com/apache/thrift/pull/2973#discussion_r1589845126


##########
lib/go/thrift/header_transport.go:
##########
@@ -449,6 +455,11 @@ func (t *THeaderTransport) parseHeaders(ctx 
context.Context, frameSize uint32) e
        }
        t.protocolID = THeaderProtocolID(protoID)
 
+       // Reset writeTransforms to the ones from cfg, as we are going to add
+       // compression transforms from what we read, we don't want to accumulate
+       // different transforms read from different requests
+       t.writeTransforms = t.cfg.GetTHeaderTransforms()

Review Comment:
   Done. Also added a real test for req and resp compression.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@thrift.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to