arkuhn commented on code in PR #2929:
URL: https://github.com/apache/thrift/pull/2929#discussion_r1615536315
##########
compiler/cpp/src/thrift/generate/t_py_generator.cc:
##########
@@ -2800,8 +2840,78 @@ string t_py_generator::type_name(t_type* ttype) {
return ttype->get_name();
}
+string t_py_generator::arg_hint(t_type* type) {
+ if (gen_type_hints_) {
+ return ": " + type_to_py_type(type);
+ }
+
+ return "";
+}
+
+string t_py_generator::member_hint(t_type* type, t_field::e_req req) {
+ if (gen_type_hints_) {
+ if (req != t_field::T_REQUIRED) {
+ return ": typing.Optional[" + type_to_py_type(type) + "]";
Review Comment:
I believe this would work, but only as of 3.10 (which is EOL in a couple
months.) Using `typing.*` and `Union` syntax allows us to target all of 3.5 to
3.12+
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@thrift.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
