Jens-G commented on PR #2999: URL: https://github.com/apache/thrift/pull/2999#issuecomment-2237666774
> > The net8 option is very deliberately placed there. > > Idea behind it was to use default compiler option in favor of specific ones. **Both net6 and net8 are not simply some arbitrary compiler options**. These directly affect some important settings and assumptions, e.g. how to treat nullable references to name just one. You cannot simply switch those options blindly and hope all will be fine. The options should match the target environment or you will indeed "find errors" that don't exist. > Is that the reason, which causes the "Test_Complex_DeepCopy" to fail with non net8/net6? I'd propose to compare the generated code for each option and/or looking at the code generator. > For that reason I came up with that "large change" version [...] use explicit options only where needed (like the net8/C#12 tests-folder). I'm fine with **adding** tests. I'm not fine with "improving" working tests to the point where there are broken. **We encourage to contribute patches**, but everybody should be aware that - like in any other FOSS project - patches will be reviewed, change-requested, modified and occasionally this involves many hours of back and forth until it gets finally accepted (or rejected). Some patches get accepted, some debated, some rejected. That's how it works. As a rule of thumb, smaller and more concise patches generally have a better chance of getting through - simply because review is easier. > [...] would need to have a "legacy" option [...] Exactly what I meant by "awkward". -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@thrift.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
