fishy commented on code in PR #3011:
URL: https://github.com/apache/thrift/pull/3011#discussion_r1691892287
##########
compiler/cpp/src/thrift/main.cc:
##########
@@ -373,7 +373,12 @@ string include_file(string filename) {
}
// Uh oh
- pwarning(0, "Could not find include file %s\n", filename.c_str());
+ if (g_strict >= 192) {
Review Comment:
so I did a `git grep -w g_strict` and the only place we check the value is
this:
```
$ git grep -w g_strict
src/thrift/globals.h:extern int g_strict;
src/thrift/main.cc:int g_strict = 127;
src/thrift/main.cc: if (g_strict >= 192) {
src/thrift/main.cc: g_strict = 255;
src/thrift/thrifty.yy: if (g_strict >= 192) {
```
so I opted with follow the existing convention :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@thrift.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
