mrcjkb commented on code in PR #3010: URL: https://github.com/apache/thrift/pull/3010#discussion_r1697093581
########## lib/java/src/main/java/org/apache/thrift/server/AbstractNonblockingServer.java: ########## @@ -302,6 +302,14 @@ public FrameBuffer( } } + /** + * Sets the selection key. + * @param selectionKey the new key to set. + */ + public void setSelectionKey(SelectionKey selectionKey) { Review Comment: Not too sure about this. It feels a bit hacky. Maybe someone who is familiar with the code base can suggest a better solution? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@thrift.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org