ctubbsii commented on PR #2793: URL: https://github.com/apache/thrift/pull/2793#issuecomment-2290629033
The current version of clover doesn't work with the version of gradle Thrift is using, so there's no harm in updating it. It's disabled by default anyway in the build. Updating the plugin gets it closer to working, but it still has an error, because the latest version of clover doesn't work with gradle 8 due to [the removal of the deprecated outputDir property of the SourceDirectorySet](https://docs.gradle.org/current/userguide/upgrading_version_7.html#sourcedirectoryset_api_cleanup) Personally, I'd be inclined to remove the coverage report plugin since it's not used in the build and doesn't work anyway, but I'm not sure if @jimexist wants to try to get it working. For now, I'll just merge this to get rid of the dependabot noise. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@thrift.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
