ctubbsii commented on PR #3022: URL: https://github.com/apache/thrift/pull/3022#issuecomment-2292301353
> in my opinion the easiest way is to just use https://github.com/gradle/wrapper-validation-action but not sure if this 3rd party (in the context of GitHub action) action is allowed? I think you mean [setup-gradle](https://github.com/gradle/actions?tab=readme-ov-file#the-setup-gradle-action)? I think it would be easy to get ASF INFRA to approve it if they haven't already. However, my bigger concerns are that they won't work correctly: 1. the `setup-gradle` action sets up the gradle wrapper in the root of the project. We only use it in `lib/java` (or `lib/kotlin`) and expect it to be set up there. I spent quite a bit of time trying to set up the gradle wrapper outside of the project tree, so it could be used only as version control (like `rvm` or `rbenv` are used to manage ruby installations), but it wouldn't work because the gradle wrapper very strictly requires being installed inside an existing project and cannot be easily used to manage versions outside of a project. Since the `setup-gradle` action doesn't have the option to specify the target directory (that I could find), we'd have to substantially change things around to have gradlew installed at the root of the project to work with this action. 2. even if we use `setup-gradle` action, I don't think `./configure` would find it without additional changes to `configure.ac`, and it would still use `gradle` from the environment when building with `make` instead of `./gradlew`. Perhaps there's a way to specify the gradle command directly using a `./configure` flag that I don't know about? If so, then perhaps we can force it to use `./gradlew` instead of `gradle`, but I don't know how to do that. My conclusion is that it's probably not worth changing right now. However, perhaps it might be possible to just simplify the installation of our preferred gradle version by installing it in local directory and adding it to the PATH, rather than trying to clobber the system-provided gradle using `sudo`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@thrift.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
