ctubbsii commented on code in PR #3017:
URL: https://github.com/apache/thrift/pull/3017#discussion_r1725405086
##########
compiler/cpp/src/thrift/generate/t_java_generator.cc:
##########
@@ -3328,6 +3328,7 @@ void t_java_generator::generate_service_client(t_service*
tservice) {
// Careful, only return _result if not a void function
if (!(*f_iter)->get_returntype()->is_void()) {
f_service_ << indent() << "if (result." <<
generate_isset_check("success") << ") {" << '\n'
+ << indent() << " after();" << '\n'
Review Comment:
Wouldn't you want this to be called even if it is a void function? Adding
this call here only calls it when it isn't a void function.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@thrift.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
