thomasbruggink commented on PR #3043: URL: https://github.com/apache/thrift/pull/3043#issuecomment-2380448000
Thanks for the pointers, I missed the nuance of the `--release` flag. As the blog post you linked points out, there currently isn't a flag in the Kotlin Gradle plugin that allows setting the `-Xjdk-release` flag. However it can be done by using the `freeCompilerArgs` as pointed out in the same blogpost. Unfortunately this conflicts with manually setting a toolchain since it generates conflicting build options. It seems the way that worked in the end is to manually define the source/target compatibility for the java plugin, then tell the Kotlin compiler to use target 1.8 and set the release flag. I think this way we could keep the cross-test-client and cross-test-server running with installed JDK? Let me know what you think. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@thrift.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
