Jens-G commented on code in PR #3051:
URL: https://github.com/apache/thrift/pull/3051#discussion_r1797403047
##########
lib/go/test/ClientMiddlewareExceptionTest.thrift:
##########
@@ -25,11 +25,11 @@ exception Exception2 {
// This is a special case, we want to make sure that the middleware don't
// accidentally pull result as error.
-exception FooResponse {
+struct/*exception*/ FooResponse { // returning an exception by any means
other than "throws" is illegal
Review Comment:
> I think I can construct the test differently [...] to keep the test to do
what it does, though.
Great, thanks!
> if your plan is to forbid that on the compiler level
I am actually thinking about this, indeed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@thrift.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
