layus commented on PR #3055: URL: https://github.com/apache/thrift/pull/3055#issuecomment-2435089532
Indeed. If only it could be made more generic. BTW, are you sure your patch works as intended? Because by adding your condition to the if branch you fall into the else branch. Might not be what you had in mind. Le 24 octobre 2024 13:46:31 GMT+02:00, Jim King ***@***.***> a écrit : >You'll want to align this to https://github.com/apache/thrift/pull/3049 which I just merged. > >-- >Reply to this email directly or view it on GitHub: >https://github.com/apache/thrift/pull/3055#issuecomment-2435052905 >You are receiving this because you authored the thread. > >Message ID: ***@***.***> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@thrift.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
