Jens-G commented on code in PR #3076: URL: https://github.com/apache/thrift/pull/3076#discussion_r1884606683
########## doc/specs/thrift-compact-protocol.md: ########## @@ -249,7 +249,7 @@ The short form should be used when the length is in the range 0 - 14 (inclusive) The following element-types are used (see note below): -* `BOOL`, encoded as `2` +* `BOOL`, encoded as `1` Review Comment: That is debatable. A better word could be inconcistent. * thrift_compact_protocol.erl does it acciotrding to the spec and writes 2 * anyone else writes 1 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@thrift.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
