Jens-G commented on code in PR #3108:
URL: https://github.com/apache/thrift/pull/3108#discussion_r1976464644
##########
lib/py/src/transport/THttpClient.py:
##########
@@ -111,8 +111,6 @@ def open(self):
timeout=self.__timeout)
elif self.scheme == 'https':
self.__http = http.client.HTTPSConnection(self.host, self.port,
- key_file=self.keyfile,
- cert_file=self.certfile,
timeout=self.__timeout,
Review Comment:
> please use ssl.SSLContext.load_cert_chain() instead, or let
ssl.create_default_context() select the system’s trusted CA certificates for
you.
Copypasted too much. I meant that part actually.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@thrift.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
