fishy commented on PR #3116: URL: https://github.com/apache/thrift/pull/3116#issuecomment-2755680802
@dcelasun changed to return an iterator instead, please take another look. iterator has the advantage of immutability over slice. it does have the disadvantage of lack of length info. if people need that, a one-time O(N) operation of `slices.Collect` or similar should be trivial. we can also provide another function to return length info, for example `func FooValuesN() int`, but the naming is kinda awkward, and I think in most use cases that info is needed, they probably would need to build a map anyways, so they need the one-time O(N) operation anyways. we can add it later if really needed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@thrift.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
