Jens-G commented on PR #3127: URL: https://github.com/apache/thrift/pull/3127#issuecomment-2845752862
> for example: Your example is broken. If someone passes in `int.Max` for len the function will try to read it w/o complaint. Exactly that should not happen. Asking `consumeReadMessageBytes()` for validation **after** you already did the `read()` it is rather pointless, because the test is intended to happen **before** we even try to read. While I appreciate the efforts you put into this, I'm still not convinced (a) we should do this at all and (b) with the quality of the patch. If there are good arguments for a patch that let me believe in it and convince me that my doubts are unfounded, I am perfectly fine with it. But so far, you only managed to increased the latter. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@thrift.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
