fishy commented on PR #3154: URL: https://github.com/apache/thrift/pull/3154#issuecomment-2919720594
> Would it make sense to also include [48b0e1c](https://github.com/apache/thrift/commit/48b0e1cb889fbe0f332742657a3e9dcb648b43fb) as part of this PR? > > I am not sure how the infrastructure is set up but it does not appear that cpp cross tests are being included, perhaps after the above commit it can also be enabled if my observation is correct @CJCombrink no that only changes which cross test for cpp to run (with or without uuid), not how it's run to include cpp into cross test in CI, you need to add a lib-cpp workflow into https://github.com/apache/thrift/blob/master/.github/workflows/build.yml, then add cpp to servers and clients at https://github.com/apache/thrift/blob/63b7a263fc669c56fedca5d9a7310902d98df335/.github/workflows/build.yml#L564-L568 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@thrift.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
