CJCombrink commented on PR #3165: URL: https://github.com/apache/thrift/pull/3165#issuecomment-2968015262
From some reading (eg. [std::iterator is deprecated: Why, What It Was, and What to Use Instead](https://www.fluentcpp.com/2018/05/08/std-iterator-deprecated/)) it seems like all 5 options must be specified when replacing the deprecated `std::iterator` This is confirmed in this change: https://github.com/CJCombrink/thrift/commit/2dd5c9d33537b6df356943559aeea6e0408c020a ([action](https://github.com/CJCombrink/thrift/actions/runs/15619527977/job/44001014743) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@thrift.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org