zsy056 commented on PR #3233: URL: https://github.com/apache/thrift/pull/3233#issuecomment-3540194080
> > The part I like about using docker is that it publishes a thrift-build image that can help folks get started with a ready-to-use environment. > > Sure it does have some benefit and it builds on top of what is already existing. _Although I am not sure who is brave enough to do local docker based development on Windows_ :P > > Just regarding the approach: I opted to use conan as a package manager instead of building dependencies manually. I think conan is more inclined to keep dependencies building and up to data compared to trying to maintain basically the same logic here. Conan also provides some pre-build packages that can speed up the build. I totally agree using Conan or vcpkg would be much better. I can switch the build script to use Conan after your change got merged. Just curious, what is wrong about local docker based development on Windows? 🤣 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
