fishy commented on code in PR #3246:
URL: https://github.com/apache/thrift/pull/3246#discussion_r2547018838
##########
compiler/cpp/tests/CMakeLists.txt:
##########
@@ -45,7 +45,7 @@ find_package(BISON REQUIRED)
file(MAKE_DIRECTORY ${CMAKE_CURRENT_BINARY_DIR}/thrift/)
# Create flex and bison files and build the lib parse static library
-BISON_TARGET(thrifty ${THRIFT_COMPILER_SOURCE_DIR}/src/thrift/thrifty.yy
${CMAKE_CURRENT_BINARY_DIR}/thrift/thrifty.cc)
+BISON_TARGET(thrifty ${THRIFT_COMPILER_SOURCE_DIR}/src/thrift/thrifty.yy
${CMAKE_CURRENT_BINARY_DIR}/thrift/thrifty.cc COMPILE_FLAGS
"--file-prefix-map=${CMAKE_BINARY_DIR}=''
--file-prefix-map=${CMAKE_SOURCE_DIR}=''")
Review Comment:
I'm not sure reproducible builds are important for tests, but again, this
probably doesn't hurt 🤷
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
