kpumuk commented on code in PR #3260:
URL: https://github.com/apache/thrift/pull/3260#discussion_r2576746737
##########
lib/cpp/test/concurrency/ThreadManagerTests.h:
##########
@@ -42,16 +44,7 @@ static void expiredNotifier(std::shared_ptr<Runnable>
runnable)
}
static void sleep_(int64_t millisec) {
- Monitor _sleep;
- Synchronized s(_sleep);
-
- try {
- _sleep.wait(millisec);
- } catch (TimedOutException&) {
- ;
- } catch (...) {
- assert(0);
- }
+ boost::this_thread::sleep_for(boost::chrono::milliseconds(millisec));
Review Comment:
I went with std:: initially, but then grepped the project and found a few
boost calls. I don't see any such calls today. I even got the example of how to
add the libraries to load from those usages.
Starting questioning my sanity, but rolled back to `std::` in the mean time,
thank you!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
