kpumuk commented on code in PR #3270:
URL: https://github.com/apache/thrift/pull/3270#discussion_r2637375138
##########
lib/rb/lib/thrift/protocol/compact_protocol.rb:
##########
@@ -276,7 +276,7 @@ def read_field_begin
# push the new field onto the field stack so we can keep the deltas
going.
@last_field.push(field_id)
- ["", CompactTypes.get_ttype(type & 0x0f), field_id]
+ [nil, CompactTypes.get_ttype(type & 0x0f), field_id]
Review Comment:
See
https://github.com/apache/thrift/blob/master/lib/rb/ext/compact_protocol.c#L488:
```c
return rb_ary_new3(3, Qnil, INT2FIX(get_ttype(type & 0x0f)),
INT2FIX(field_id));
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
