Jens-G commented on code in PR #3331:
URL: https://github.com/apache/thrift/pull/3331#discussion_r2921153096


##########
compiler/cpp/src/thrift/generate/t_js_generator.cc:
##########
@@ -742,6 +750,10 @@ string t_js_generator::render_const_value(t_type* type, 
t_const_value* value) {
     case t_base_type::TYPE_STRING:
       out << "'" << get_escaped_string(value) << "'";
       break;
+    case t_base_type::TYPE_UUID:
+      // The UUID should be in the correct string format already the 
get_escaped* might be redundant
+      out << "'" << get_escaped_string(value) << "'";

Review Comment:
   What does that comment tell me?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to