japm48 commented on PR #2649: URL: https://github.com/apache/thrift/pull/2649#issuecomment-4322400132
About this issue, I can see several solutions: 1. Use a compiler define/macro (e.g. `THRIFT_WIN_HDR_LOWERCASE`) and use ifdefs for this. Drawback: lots of noise. 2. Use the same compiler define, but use a global header (e.g. `thrift_windows.h`) with an ifdef and include all required windows headers. Also, maybe define WIN32_LEAN_AND_MEAN in there, and apply the max/min undefines. Drawbacks: potential for slower compilation (maybe fine in practice), and I'm not sure where that should live in this codebase (maybe global headers are considered not acceptable). 4. Use this patch. Names are wrong in theory, but case insensitivity kicks in in practice. I'd favor: 2 > 3 > 1. Thoughts? @emmenlau , @evetion -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
