ShemShadrack commented on code in PR #3399:
URL: https://github.com/apache/thrift/pull/3399#discussion_r3196567170
##########
lib/rs/src/transport/socket.rs:
##########
@@ -141,9 +196,13 @@ impl TIoChannel for TTcpChannel {
.map(|cloned| {
let read_half = ReadHalf::new(TTcpChannel {
stream: s.stream.take(),
+ read_timeout: s.read_timeout,
Review Comment:
on the design. Worth noting though: read_timeout() already reads directly
from the OS socket when the stream is open, so stale in your example would
actually equal `updated` the getter never returns the cached field while
connected. Yeah still, having diverged caches after split is still bad, so I
fixed `split()` to read both timeouts from the live socket rather than copying
the struct fields. Caches are now consistent from the start and the regression
test covers the scenario shared .
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
