fishy commented on code in PR #3458:
URL: https://github.com/apache/thrift/pull/3458#discussion_r3220289407
##########
lib/go/thrift/common_test.go:
##########
@@ -103,4 +105,39 @@ func (p *mockWrappableProcessor) AddToProcessorMap(name
string, processorFunc TP
var (
_ TProcessor = (*mockProcessor)(nil)
_ TProcessor = (*mockWrappableProcessor)(nil)
+ _ net.Conn = (*mockConn)(nil)
)
+
+type mockConn struct{}
Review Comment:
since this is only used in socket_conn_test.go, let's move it there. putting
it here is a bit too broad (this mock cannot be used as generic connection
alternative in tests either, it's only for very specific cases)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
